RDKEMW-22169:Updated version to 4.4.6 - #414
Open
RajaLucy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dependency build script to pin Thunder-related repositories to the R4.4.6 release tag, aligning local dependency checkouts with the intended version bump.
Changes:
- Update
ThunderToolsclone tag toR4.4.6. - Update
Thunderclone tag toR4.4.6.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
build_dependencies.sh:36
- The script runs with
set -x, and thegit cloneURL embeds$GITHUB_TOKEN. This can expose the token in CI logs (xtrace will echo the expanded command). Disable xtrace around this clone (or use an auth mechanism that doesn't place the token in the URL).
git clone --branch R4.4.6 https://github.com/rdkcentral/Thunder.git
git clone --branch develop https://github.com/rdkcentral/entservices-apis.git
git clone https://$GITHUB_TOKEN@github.com/rdkcentral/entservices-testframework.git
build_dependencies.sh:62
- Typo in log output:
buliding thunder->building thunder. Fixing this makes CI logs easier to scan/search.
echo "buliding thunder"
cd Thunder
patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/error_code_R4_4_6.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Updated Thunder and ThunderTools version to 4.4.6.
Test Procedure: Refer ticket.
Risks: Medium.
Priority: P0.
Version: Patch